lkml.org 
[lkml]   [2016]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)
Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.huwei@huawei.com wrote:

<snip>

>+int hns_roce_buf_alloc(
>+ struct hns_roce_dev *hr_dev,
>+ int size, int max_direct,
>+ struct hns_roce_buf *buf)

<snip>

>+
>+ pages =
>+ kmalloc(sizeof(*pages) * buf->nbufs,
>+ GFP_KERNEL);

<snip>

>+
>+ buf->direct.buf = vmap(
>+ pages, buf->nbufs, VM_MAP,
>+ PAGE_KERNEL);

<snip>

>+ if (
>+ event_type != HNS_ROCE_EVENT_TYPE_CQ_ID_INVALID &&
>+ event_type != HNS_ROCE_EVENT_TYPE_CQ_ACCESS_ERROR &&
>+ event_type != HNS_ROCE_EVENT_TYPE_CQ_OVERFLOW) {
>+ dev_err(&hr_dev->pdev->dev,
>+ "hns_roce_ib: Unexpected event type 0x%x on CQ %06x\n",
>+ event_type, hr_cq->cqn);
>+ return;
>+ }

Although checkpatch does not complain, I find this semi-random adding of
newlines quite odd.

\
 
 \ /
  Last update: 2016-03-04 11:01    [W:0.110 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site