Messages in this thread | | | Date | Fri, 1 Apr 2016 00:21:39 +0530 | From | "Naveen N. Rao" <> | Subject | Re: [PATCH 3/4] samples/bpf: Simplify building BPF samples |
| |
On 2016/03/31 10:49AM, Alexei Starovoitov wrote: > On 3/31/16 4:25 AM, Naveen N. Rao wrote: > >Make BPF samples build depend on CONFIG_SAMPLE_BPF. We still don't add a > >Kconfig option since that will add a dependency on llvm for allyesconfig > >builds which may not be desirable. > > > >Those who need to build the BPF samples can now just do: > > > >make CONFIG_SAMPLE_BPF=y > > > >or: > > > >export CONFIG_SAMPLE_BPF=y > >make > > I don't like this 'simplification'. > make samples/bpf/ > is much easier to type than capital letters.
This started out as a patch to have the BPF samples built with a Kconfig option. As stated in the commit description, I realised that it won't work for allyesconfig builds. However, the reason I retained this patch is since it gets us one step closer to building the samples as part of the kernel build.
The 'simplification' is since I can now have the export in my .bashrc and the kernel build will now build the BPF samples too without requiring an additional 'make samples/bpf/' step.
I agree this is subjective, so I am ok if this isn't taken in.
- Naveen
| |