Messages in this thread | | | Date | Wed, 30 Mar 2016 12:11:14 -0500 | From | Dinh Nguyen <> | Subject | Re: [PATCH 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup |
| |
On Wed, 30 Mar 2016, tthayer@opensource.altera.com wrote:
> From: Thor Thayer <tthayer@opensource.altera.com> > > Enable ECC for Arria10 On-Chip RAM on machine startup. The ECC has to be > enabled before data is stored in memory otherwise the ECC will fail > on reads. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > ---
[snip]
> + > +void socfpga_init_arria10_ocram_ecc(void) > +{ > + struct device_node *np; > + int ret; > + > + /* Find the OCRAM EDAC device tree node */ > + np = of_find_compatible_node(NULL, NULL, "altr,socfpga-a10-ocram-ecc"); > + if (!np) { > + pr_err("Unable to find socfpga-a10-ocram-ecc\n"); > + return; > + } > + > + ret = altr_init_a10_ecc_block(np, A10_SYSMGR_ECC_INTSTAT_OCRAM, > + ALTR_A10_OCRAM_ECC_EN_CTL, 0);
I think this is a no-no, you shouldn't be making a call directly into the driver from here.
BR, Dinh
| |