lkml.org 
[lkml]   [2016]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv3 17/29] thp: prepare change_huge_pmd() for file thp
    Date
    change_huge_pmd() has assert which is not relvant for file page.
    For shared mapping it's perfectly fine to have page table entry
    writable, without explicit mkwrite.

    Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    ---
    mm/huge_memory.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/mm/huge_memory.c b/mm/huge_memory.c
    index c0ffa6a7803a..29a687cbef40 100644
    --- a/mm/huge_memory.c
    +++ b/mm/huge_memory.c
    @@ -1756,7 +1756,8 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd,
    entry = pmd_mkwrite(entry);
    ret = HPAGE_PMD_NR;
    set_pmd_at(mm, addr, pmd, entry);
    - BUG_ON(!preserve_write && pmd_write(entry));
    + BUG_ON(vma_is_anonymous(vma) && !preserve_write &&
    + pmd_write(entry));
    }
    spin_unlock(ptl);
    }
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-03 18:41    [W:4.395 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site