lkml.org 
[lkml]   [2016]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] extcon: usb-gpio: add support for ACPI gpio interface
Hi Lu,

On 2016년 03월 03일 15:37, Lu Baolu wrote:
> GPIO resource could be retrieved through APCI as well.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Felipe Balbi <balbi@kernel.org>
> ---
> drivers/extcon/extcon-usb-gpio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index af9c8b0..472c431 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -26,6 +26,7 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/workqueue.h>
> +#include <linux/acpi.h>
>
> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */
>
> @@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev)
> struct usb_extcon_info *info;
> int ret;
>
> - if (!np)
> + if (!np && !ACPI_HANDLE(dev))
> return -EINVAL;
>
> info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
>

Looks good to me.

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Best Regards,
Chanwoo Choi

\
 
 \ /
  Last update: 2016-03-03 09:01    [W:0.397 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site