lkml.org 
[lkml]   [2016]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [rtc-linux] Re: [RFC 09/15] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM
    From
    2016-03-03 19:57 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
    > On Thursday 03 March 2016 17:03:35 Krzysztof Kozlowski wrote:
    >> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
    >> index 201f5c296a95..e5931e434fa2 100644
    >> --- a/drivers/media/platform/Kconfig
    >> +++ b/drivers/media/platform/Kconfig
    >> @@ -79,6 +79,7 @@ config VIDEO_OMAP3
    >> depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && ARCH_OMAP3
    >> depends on HAS_DMA && OF
    >> depends on OMAP_IOMMU
    >> + depends on HAS_IOMEM # For MFD_SYSCON
    >> select ARM_DMA_USE_IOMMU
    >> select VIDEOBUF2_DMA_CONTIG
    >
    > This is only built for OMAP3, so we won't get here without HAS_IOMEM

    Indeed.

    >
    >> select MFD_SYSCON
    >> diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig
    >> index 57d42c6172c5..c4317b99d257 100644
    >> --- a/drivers/media/platform/exynos4-is/Kconfig
    >> +++ b/drivers/media/platform/exynos4-is/Kconfig
    >> @@ -17,6 +17,7 @@ config VIDEO_S5P_FIMC
    >> tristate "S5P/EXYNOS4 FIMC/CAMIF camera interface driver"
    >> depends on I2C
    >> depends on HAS_DMA
    >> + depends on HAS_IOMEM # For MFD_SYSCON
    >> select VIDEOBUF2_DMA_CONTIG
    >> select V4L2_MEM2MEM_DEV
    >
    > This is guarded by HAS_DMA, which implies HAS_IOMEM afaik.

    Looking at Kconfigs - no, it is not implied (or am I missing
    something)... and sometimes dependency on HAS_IOMEM is next to
    HAS_DMA.

    BR,
    Krzysztof

    \
     
     \ /
      Last update: 2016-03-03 14:21    [W:3.295 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site