Messages in this thread | | | Subject | Re: [PATCH] gpio: pca953x: Use correct u16 value for register word write | From | Phil Reid <> | Date | Wed, 30 Mar 2016 00:33:28 +0800 |
| |
On 29/03/2016 10:39 PM, Alexander Stein wrote: > You missed CC'ing Phil (Added for this post) > > On Tuesday 29 March 2016 20:53:58, Yong Li wrote: >> Thanks for your comment, I think I can change it to val[0] | (val[1] >> << 8), is it okay ? > > Mh, currently there is only one caller (device_pca953x_init) which passes only > 0, 0 or 0xff, 0xff, so endianess is irrelevant. But to be future proof this > should be done in an endian-safe manner. Though cpu_to_le16p does not work, > due to same alignment problem as casting to u16*. >
I think get_unaligned((u16 *) val) should do the job. There's also get_unaligned_le* get_unaligned_be*
-- Regards Phil Reid
| |