lkml.org 
[lkml]   [2016]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: lenovo: Don't use stack variables for DMA buffers
On Tue, 29 Mar 2016, Benjamin Tissoires wrote:

> > The lenovo_send_cmd_cptkbd function uses a stack variable to submit
> > commands via hid_hw_raw_request. Eventually this gets to the
> > usb_hcd_map_urb_for_dma function, which causes a warning to be thrown
> > if the CONFIG_DMA_API_DEBUG option is enabled.
> >
> > Fix this by allocating a temporary buffer instead.
> >
> > Reported-by: lejeczek <peljasz@yahoo.co.uk>
> > Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> > ---
>
> The patch is
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> There is just one nitpick that can be solved while committing (or not,
> depending on how Jiri handles it :-P ).

I've nuked the NULL-initialization and applied, thanks!

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2016-03-29 16:21    [W:0.196 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site