Messages in this thread | | | Date | Wed, 30 Mar 2016 03:12:40 +0200 | Subject | Re: [PATCH v6 7/7][Resend] cpufreq: schedutil: New governor based on scheduler utilization data | From | "Rafael J. Wysocki" <> |
| |
On Tue, Mar 29, 2016 at 2:58 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Monday, March 28, 2016 02:33:33 PM Viresh Kumar wrote: >> On 22-03-16, 02:54, Rafael J. Wysocki wrote:
[cut]
>> > +static unsigned int sugov_next_freq_shared(struct sugov_policy *sg_policy, >> > + unsigned long util, unsigned long max) >> > +{ >> > + struct cpufreq_policy *policy = sg_policy->policy; >> > + unsigned int max_f = policy->cpuinfo.max_freq; >> > + u64 last_freq_update_time = sg_policy->last_freq_update_time; >> > + unsigned int j; >> > + >> > + if (util == ULONG_MAX) >> > + return max_f; >> > + >> > + for_each_cpu(j, policy->cpus) { >> > + struct sugov_cpu *j_sg_cpu; >> > + unsigned long j_util, j_max; >> > + u64 delta_ns; >> > + >> > + if (j == smp_processor_id()) >> > + continue; >> >> Why skip local CPU completely ? > > Because the original util and max come from it. > >> And if we really want to do that, what about something like for_each_cpu_and_not >> to kill the unnecessary if {} statement ? > > That will work.
Except that for_each_cpu_and_not is not defined as of today.
I guess I can play with cpumasks, but then I'm not sure that will end up actually more efficient.
| |