Messages in this thread | | | Date | Mon, 28 Mar 2016 16:12:08 +0800 | Subject | Re: [PATCH 05/11] mtd: nand: use new BBT API instead of old ones | From | Peter Pan <> |
| |
On Fri, Mar 25, 2016 at 4:51 PM, Boris Brezillon <boris.brezillon@free-electrons.com> wrote: > On Mon, 14 Mar 2016 02:47:58 +0000 > Peter Pan <peterpansjtu@gmail.com> wrote: > >> Use new BBT APIs (nand_bbt_*()) in NAND. Keep old APIs (nand_*_bbt()) >> exist temporarily. >> >> Signed-off-by: Brian Norris <computersforpeace@gmail.com> >> Signed-off-by: Peter Pan <peterpandong@micron.com> >> --- >> drivers/mtd/nand/docg4.c | 7 +- >> drivers/mtd/nand/nand_base.c | 151 ++++++++++++++++++++++++++++++++++++++++--- >> include/linux/mtd/nand.h | 15 ++++- >> 3 files changed, 160 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c >> index b6facac..6f0e3b9 100644 >> --- a/drivers/mtd/nand/nand_base.c >> +++ b/drivers/mtd/nand/nand_base.c > > [...] > >> +static int nand_default_bbt(struct mtd_info *mtd) >> +{ >> + struct nand_chip *chip = mtd_to_nand(mtd); >> + struct nand_bbt *nand_bbt = NULL; >> + struct nand_chip_layout_info *info = >> + kzalloc(sizeof(struct nand_chip_layout_info), GFP_KERNEL); > > No, this should be directly embedded in nand_chip, and should replace > the numchips/chipsize/... fields declared in there.
As I said in patch 2, I keep it like this temporarily. Will embedded it in struct nand_chip later.
Thanks, Peter Pan
| |