lkml.org 
[lkml]   [2016]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf config: Tidy up the code setting buildid dir
From
Date
Hi, jirka

Thank you for your review :-)

On 03/27/2016 08:16 PM, Jiri Olsa wrote:
> On Thu, Mar 24, 2016 at 04:49:33PM +0900, Taeung Song wrote:
>> Add new perf_buildid_config() into perf_default_config,
>> bring set_buildid_dir() next to perf_default_config,
>> rename some variable name as more readable name and etc
>> in order to clean up code about buildid dir.
>>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Wang Nan <wangnan0@huawei.com>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>> ---
>> tools/perf/perf.c | 3 +--
>> tools/perf/util/config.c | 57 +++++++++++++++++++-----------------------------
>> 2 files changed, 23 insertions(+), 37 deletions(-)
>
> though it's failry simple change we try to separate changes
>
> seems like 3 independent changes:
>
> - perf.c hunk change
> - buildid_dir_command_config/perf_buildid_config rework
> - set_buildid_dir fix
>

You mean it is needed to separate this patch as 3 part?
I got it.

I'll resend the patchset.

Thanks,
Taeung

\
 
 \ /
  Last update: 2016-03-27 18:21    [W:0.403 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site