lkml.org 
[lkml]   [2016]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/2] arm64: cpuidle: remove cpu_ops check from arm_cpuidle_suspend()
Date
If cpu_ops has not been registered, arm_cpuidle_init() will return
-EOPNOTSUPP, so arm_cpuidle_suspend() will never have chance to
run. In other word, the cpu_ops check can be avoid.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
arch/arm64/kernel/cpuidle.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/kernel/cpuidle.c b/arch/arm64/kernel/cpuidle.c
index 9047cab6..bd57c59 100644
--- a/arch/arm64/kernel/cpuidle.c
+++ b/arch/arm64/kernel/cpuidle.c
@@ -37,10 +37,9 @@ int arm_cpuidle_suspend(int index)
int cpu = smp_processor_id();

/*
- * If cpu_ops have not been registered or suspend
- * has not been initialized, cpu_suspend call fails early.
+ * If suspend has not been initialized, cpu_suspend call fails early.
*/
- if (!cpu_ops[cpu] || !cpu_ops[cpu]->cpu_suspend)
+ if (!cpu_ops[cpu]->cpu_suspend)
return -EOPNOTSUPP;
return cpu_ops[cpu]->cpu_suspend(index);
}
--
2.8.0.rc3
\
 
 \ /
  Last update: 2016-03-24 07:01    [W:0.094 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site