lkml.org 
[lkml]   [2016]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] selinux: fix memory leak on node_ptr on error return path
From
On Tue, Mar 22, 2016 at 4:28 PM, Serge E. Hallyn <serge@hallyn.com> wrote:
> Quoting Colin King (colin.king@canonical.com):
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> node_ptr is not being free'd if the list allocation fails, fix
>> this by kfree'ing it before exiting on the error path.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Hi,
>
> I'm not very familiar with this code any more, but are you sure
> this is needed and doesn't cause a new bug? It *looks* like
> the avtab_insert_nonunique() actually inserts the node_ptr
> into the policydb, and the policydb is the one that should
> eventually free it.

Exactly. cond_insertf() calls avtab_insert_nonunique() which calls
avtab_insert_node() which adds the node to the avtab. The avtab will
get cleaned up later by the error handling code in the cond_insertf()
call chain.

--
paul moore
www.paul-moore.com

\
 
 \ /
  Last update: 2016-03-22 23:21    [W:0.053 / U:1.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site