lkml.org 
[lkml]   [2016]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 053/142] net: phy: bcm7xxx: Fix shadow mode 2 disabling
    Date
    3.16.7-ckt26 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Florian Fainelli <f.fainelli@gmail.com>

    commit 50d899808d33a5b0aa82be23e824119944042689 upstream.

    The clear and set masks in the call to phy_set_clr_bits() called from
    bcm7xxx_config_init() are inverted. We need to fix this by swapping the two
    arguments, that is, set 0 bits, but clear the shade mode 2 enable bit.

    Fixes: b560a58c45c66 ("net: phy: add Broadcom BCM7xxx internal PHY driver")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/phy/bcm7xxx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c
    index 526b94cea569..51678e393793 100644
    --- a/drivers/net/phy/bcm7xxx.c
    +++ b/drivers/net/phy/bcm7xxx.c
    @@ -204,7 +204,7 @@ static int bcm7xxx_config_init(struct phy_device *phydev)
    phy_write(phydev, MII_BCM7XXX_100TX_FALSE_CAR, 0x7555);

    /* reset shadow mode 2 */
    - ret = phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, MII_BCM7XXX_SHD_MODE_2, 0);
    + ret = phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, 0, MII_BCM7XXX_SHD_MODE_2);
    if (ret < 0)
    return ret;

    \
     
     \ /
      Last update: 2016-03-22 13:01    [W:4.118 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site