lkml.org 
[lkml]   [2016]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] fs, mm: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
On Mon, Mar 21, 2016 at 12:29:34PM -0500, Christoph Lameter wrote:
> On Mon, 21 Mar 2016, Kirill A. Shutemov wrote:
>
> > We do have two page sizes in the page cache. It's the only option to get
> > transparent huge pages transparent.
>
> Should then not PAGE_CACHE_SIZE take a page parameter and return the
> correct page size?

Why? What would you achieve by this?

We already have a way to find out size of page: compoun_order() or
hpage_nr_pages().

And not in every place where PAGE_CACHE_SIZE is used we have corresponding
struct page.

--
Kirill A. Shutemov

\
 
 \ /
  Last update: 2016-03-22 12:21    [W:1.659 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site