Messages in this thread | | | Date | Tue, 22 Mar 2016 13:41:13 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH 0/3] fs, mm: get rid of PAGE_CACHE_* and page_cache_{get,release} macros |
| |
On Mon, Mar 21, 2016 at 12:29:34PM -0500, Christoph Lameter wrote: > On Mon, 21 Mar 2016, Kirill A. Shutemov wrote: > > > We do have two page sizes in the page cache. It's the only option to get > > transparent huge pages transparent. > > Should then not PAGE_CACHE_SIZE take a page parameter and return the > correct page size?
Why? What would you achieve by this?
We already have a way to find out size of page: compoun_order() or hpage_nr_pages().
And not in every place where PAGE_CACHE_SIZE is used we have corresponding struct page.
-- Kirill A. Shutemov
| |