lkml.org 
[lkml]   [2016]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM
    From
    Date
    On Sun, 2016-03-20 at 11:43 +0100, Geert Uytterhoeven wrote:
    > If CONFIG_PM=n:
    >
    > drivers/net/usb/lan78xx.c: In function ‘lan78xx_get_stats64’:
    > drivers/net/usb/lan78xx.c:3274: error: ‘struct dev_pm_info’ has no
    > member named ‘runtime_auto’
    >
    > If PM is disabled, the runtime_auto flag is not available, but auto
    > suspend is not enabled anyway. Hence protect the check for
    > runtime_auto
    > by #ifdef CONFIG_PM to fix this.
    >
    > Fixes: a59f8c5b048dc938 ("lan78xx: add ndo_get_stats64")
    > Reported-by: Guenter Roeck <linux@roeck-us.net>
    > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    > ---
    > Alternatively, we can add a dev_pm_runtime_auto_is_enabled() wrapper
    > to
    > include/linux/pm.h, which always return false if CONFIG_PM is
    > disabled.

    That is what we do for almost everything else in include/pm_runtime.h
    So it is the best solution to add the stub.

    Regards
    Oliver


    \
     
     \ /
      Last update: 2016-03-21 10:01    [W:4.118 / U:0.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site