lkml.org 
[lkml]   [2016]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] Btrfs: Code Cleanup
From
Date


Hi Flex,


> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 366b335..5c16f04 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -2325,7 +2325,10 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
> if (seeding_dev) {
> sb->s_flags &= ~MS_RDONLY;

This is not undone in the failure code. Theoretically
it should report error during unmount, did you notice ?

(in general, $subject can be more specific).

Thanks, Anand

> ret = btrfs_prepare_sprout(root);
> - BUG_ON(ret); /* -ENOMEM */
> + if (ret) {
> + btrfs_abort_transaction(trans, root, ret);
> + goto error_trans;
> + }
> }
>
> device->fs_devices = root->fs_info->fs_devices;
>

\
 
 \ /
  Last update: 2016-03-21 10:01    [W:0.054 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site