Messages in this thread | | | Date | Wed, 2 Mar 2016 14:22:51 +0100 | From | Borislav Petkov <> | Subject | Re: [v2 PATCH 1/3] panic: Change nmi_panic from macro to function |
| |
On Wed, Mar 02, 2016 at 02:18:24PM +0100, Michal Hocko wrote: > On Wed 02-03-16 19:36:26, Hidehiro Kawai wrote: > [...] > > +void nmi_panic(struct pt_regs *regs, const char *fmt, ...) > > Do we really need vargs? All the current users seem to be OK with a > simple string. This makes the code slightly more complicated without any > apparent reason.
I was just wondering the exactly same thing...
The contra-arg would be that in case someone wants to do nmi_panic() with more than a string, then it won't work.
The question is, does nmi_panic() even need to dump something more than regs and a string?
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |