Messages in this thread | | | Date | Wed, 2 Mar 2016 12:05:39 +0100 | Subject | Re: [PATCH 4/8] drivers/pinctrl: make sh-pfc/core.c explicitly non-modular | From | Geert Uytterhoeven <> |
| |
On Mon, Feb 29, 2016 at 9:48 PM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > The Kconfig / Makefile currently controlling compilation of this code is: > > drivers/pinctrl/sh-pfc/Makefile:obj-$(CONFIG_PINCTRL_SH_PFC) += sh-pfc.o > drivers/pinctrl/sh-pfc/Makefile:sh-pfc-objs = core.o pinctrl.o > > drivers/pinctrl/sh-pfc/Kconfig:config PINCTRL_SH_PFC > drivers/pinctrl/sh-pfc/Kconfig: def_bool y > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init already wasn't being used in this code, the init > ordering remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Linus: Feel free to take this with the other patches from the series. Or do you prefer I queue it up in sh-pfc-for-v4.7?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |