lkml.org 
[lkml]   [2016]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[v2 PATCH 2/3] ipmi/watchdog: Use nmi_panic() when kernel panics in NMI handler
    From
    Date
    commit 1717f2096b54 ("panic, x86: Fix re-entrance problem due to
    panic on NMI") introduced nmi_panic() which prevents concurrent and
    recursive execution of panic(). It also saves registers for the
    crash dump on x86 by later commit 58c5661f2144 ("panic, x86: Allow
    CPUs to save registers even if looping in NMI context").

    ipmi_watchdog driver can call panic() from NMI handler, so replace
    it with nmi_panic().

    Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
    Acked-by: Corey Minyard <cminyard@mvista.com>
    Acked-by: Guenter Roeck <linux@roeck-us.net>
    Reviewed-by: Michal Hocko <mhocko@suse.com>
    Cc: openipmi-developer@lists.sourceforge.net
    ---
    drivers/char/ipmi/ipmi_watchdog.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
    index 096f0ce..4facc75 100644
    --- a/drivers/char/ipmi/ipmi_watchdog.c
    +++ b/drivers/char/ipmi/ipmi_watchdog.c
    @@ -1140,7 +1140,7 @@ ipmi_nmi(unsigned int val, struct pt_regs *regs)
    the timer. So do so. */
    pretimeout_since_last_heartbeat = 1;
    if (atomic_inc_and_test(&preop_panic_excl))
    - panic(PFX "pre-timeout");
    + nmi_panic(regs, PFX "pre-timeout");
    }

    return NMI_HANDLED;

    \
     
     \ /
      Last update: 2016-03-02 12:21    [W:3.866 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site