Messages in this thread | | | Subject | Re: [rtc-linux] Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral | From | Javier Martinez Canillas <> | Date | Fri, 18 Mar 2016 10:56:08 -0300 |
| |
Hello Krzysztof,
On 03/18/2016 09:20 AM, Krzysztof Kozlowski wrote: > On Fri, Mar 18, 2016 at 9:07 PM, Alexandre Belloni >> On 18/03/2016 at 08:57:57 -0300, Javier Martinez Canillas wrote :
[snip]
>>> >>> Just to make sure that I understood correctly, there's no action I >>> should take in order for this patch to be picked right? IOW, the >>> current version is OK? >>> >> >> I was kind of waiting an answer on the question whether the core already >> prints a message when probe dereferral happens because in that case, >> there is no need for a debug message and we can indeed simplify the >> whole block. > > Although I did not test it, I think the core will print generic defer > message. See really_probe() around line 400: > http://lxr.free-electrons.com/source/drivers/base/dd.c?v=4.4#L347 > > However the cause of deferring will not be printed... so I find some > use of debug message in driver... On the other hand, not many drivers > are doing this. Ehh, I guess I am just really picky. :) >
It's Ok, I also have doubts about which direction to take even when writing trivial patches like $SUBJECT, so I understand the feeling :)
> BR, > Krzysztof >
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |