Messages in this thread | | | Subject | Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header | From | Suravee Suthikulpanit <> | Date | Fri, 18 Mar 2016 17:06:23 +0700 |
| |
On 03/18/2016 04:29 PM, Borislav Petkov wrote: > On Fri, Mar 18, 2016 at 04:09:33PM +0700, Suravee Suthikulpanit wrote: >> But the whole point is that since we are moving it to consolidate these >> duplicated declarations, I think we should just put it in the most common >> place. The include/linux/amd-iommu.h file is already there. It's not like we >> have to create a brand new file, and then having to move it later. > > Strictly speaking, it was wrong to put it there in the first place as it > is x86-specific. >
If not here, where would you prefer? Consolidating it to arch/x86/include/asm/amd-iommu.h)?
And if that's the case, should I also move include/linux/amd-iommu.h as well?
Thanks, Suravee
| |