lkml.org 
[lkml]   [2016]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()
On 16-03-16, 14:12, Rafael J. Wysocki wrote:
> No, it won't. This might be applicable to other governors, but not to
> "performance" (look at what it does on _START instead of just
> guessing).
>
> > So, your patch break things for sure.
>
> I'm not actually sure it breaks anything.
>
> Theoretically, it may, but practically? Is there any system out there
> where it makes any difference?

AFAIU, this patch will break currently working governors.

-> cpufreq_resume()
-> cpufreq_governor_performance(START)
-> __cpufreq_driver_target(target_freq = policy->max)
//policy->cur is already set to policy->max before suspend.
if (target_freq == policy->cur)
return 0;

And so, the real frequency stays to 500 MHz and policy->cur contains 1 GHz.

--
viresh

\
 
 \ /
  Last update: 2016-03-17 08:21    [W:0.088 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site