lkml.org 
[lkml]   [2016]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 48/70] ovl: copy new uid/gid into overlayfs runtime inode
    Date
    v3.19.8-ckt17 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Konstantin Khlebnikov <koct9i@gmail.com>

    commit b81de061fa59f17d2730aabb1b84419ef3913810 upstream.

    Overlayfs must update uid/gid after chown, otherwise functions
    like inode_owner_or_capable() will check user against stale uid.
    Catched by xfstests generic/087, it chowns file and calls utimes.

    Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
    Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    fs/overlayfs/inode.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
    index 8525e67..e7a505c 100644
    --- a/fs/overlayfs/inode.c
    +++ b/fs/overlayfs/inode.c
    @@ -55,6 +55,8 @@ int ovl_setattr(struct dentry *dentry, struct iattr *attr)

    mutex_lock(&upperdentry->d_inode->i_mutex);
    err = notify_change(upperdentry, attr, NULL);
    + if (!err)
    + ovl_copyattr(upperdentry->d_inode, dentry->d_inode);
    mutex_unlock(&upperdentry->d_inode->i_mutex);
    }
    ovl_drop_write(dentry);
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-16 22:01    [W:4.757 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site