lkml.org 
[lkml]   [2016]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks
From
Date
On 03/16/2016 07:27 AM, Sergei Shtylyov wrote:
>>
>> +static struct clk usb20_clk = {
>> + .name = "usb20",
>> + .parent = &pll0_sysclk2,
>> + .lpsc = DA8XX_LPSC1_USB20,
>> + .gpsc = 1,
>> +};
>
> Why move it?

For organization, to keep all of the USB clocks together. I can leave it
alone if that is preferred.

>> +
>> + /* Set the mux depending on the parent clock. */
>> + if (clk->parent == &pll0_aux_clk)
>> + val |= CFGCHIP2_USB2PHYCLKMUX;
>> + else if (clk->parent == &usb_ref_clk)
>> + val &= ~CFGCHIP2_USB2PHYCLKMUX;
>
> Don't we have clk_set_parent()for that?

Yes. clk_set_parent() is already called in a loop for all clocks
elsewhere, so not needed here.

---

Thank you for the careful review. I will address the other problems you
pointed out.

\
 
 \ /
  Last update: 2016-03-16 19:41    [W:0.109 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site