lkml.org 
[lkml]   [2016]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: unisys: visornic: Fixed Checkpatch Warnings
On Wed, Mar 16, 2016 at 06:24:47PM -0700, Gavin O'Leary wrote:
> Fixed the coding style checkpatch warnings.

Which ones? Always be specific. And only fix one type of thing at a
time.

>
> Signed-off-by: Gavin O'Leary <gavinoleary3@gmail.com>
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 0519470..0366624 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1218,8 +1218,9 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
> /* length rcvd is greater than firstfrag in this skb rcv buf */
> skb->tail += RCVPOST_BUF_SIZE; /* amount in skb->data */
> skb->data_len = skb->len - RCVPOST_BUF_SIZE; /* amount that
> - will be in
> - frag_list */
> + * will be in
> + * frag_list
> + */

Tell me that looks better :(

Please fix this properly.

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-03-17 03:21    [W:0.139 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site