lkml.org 
[lkml]   [2016]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 33/98] ALSA: timer: Fix ioctls for X32 ABI
    Date
    4.2.8-ckt6 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit b24e7ad1fdc22177eb3e51584e1cfcb45d818488 upstream.

    X32 ABI takes the 64bit timespec, thus the timer user status ioctl becomes
    incompatible with IA32. This results in NOTTY error when the ioctl is
    issued.

    Meanwhile, this struct in X32 is essentially identical with the one in
    X86-64, so we can just bypassing to the existing code for this
    specific compat ioctl.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    sound/core/timer_compat.c | 13 +++++++++++++
    1 file changed, 13 insertions(+)

    diff --git a/sound/core/timer_compat.c b/sound/core/timer_compat.c
    index 8e7eddf..2e90822 100644
    --- a/sound/core/timer_compat.c
    +++ b/sound/core/timer_compat.c
    @@ -89,12 +89,21 @@ static int snd_timer_user_status_compat(struct file *file,
    return 0;
    }

    +#ifdef CONFIG_X86_X32
    +/* X32 ABI has the same struct as x86-64 */
    +#define snd_timer_user_status_x32(file, s) \
    + snd_timer_user_status(file, s)
    +#endif /* CONFIG_X86_X32 */
    +
    /*
    */

    enum {
    SNDRV_TIMER_IOCTL_INFO32 = _IOR('T', 0x11, struct snd_timer_info32),
    SNDRV_TIMER_IOCTL_STATUS32 = _IOW('T', 0x14, struct snd_timer_status32),
    +#ifdef CONFIG_X86_X32
    + SNDRV_TIMER_IOCTL_STATUS_X32 = _IOW('T', 0x14, struct snd_timer_status),
    +#endif /* CONFIG_X86_X32 */
    };

    static long snd_timer_user_ioctl_compat(struct file *file, unsigned int cmd, unsigned long arg)
    @@ -123,6 +132,10 @@ static long snd_timer_user_ioctl_compat(struct file *file, unsigned int cmd, uns
    return snd_timer_user_info_compat(file, argp);
    case SNDRV_TIMER_IOCTL_STATUS32:
    return snd_timer_user_status_compat(file, argp);
    +#ifdef CONFIG_X86_X32
    + case SNDRV_TIMER_IOCTL_STATUS_X32:
    + return snd_timer_user_status_x32(file, argp);
    +#endif /* CONFIG_X86_X32 */
    }
    return -ENOIOCTLCMD;
    }
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-16 01:41    [W:5.150 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site