lkml.org 
[lkml]   [2016]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention
From
Date
On 03/15/2016 04:19 AM, Finn Thain wrote:
>
> On Mon, 14 Mar 2016, Hannes Reinecke wrote:
>
>>> @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S
>>> NCR5380_read(RESET_PARITY_INTERRUPT_REG);
>>> *data = d + c;
>>> *count = 0;
>>> - *phase = NCR5380_read(STATUS_REG) & PHASE_MASK;
>>> - return foo;
>>> + return result;
>>> }
>>>
>>> /*
>>
>> Don't you miss a phase update here?
>
> I guess I missed explaining the change in the commit log.
>
> The *phase assignment is redundant because after NCR5380_transfer_dma()
> returns control to NCR5380_information_transfer(), the latter routine then
> also returns, and so *phase is dead.
>
Right. Please add this to the commit message.

Otherwise:

Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

\
 
 \ /
  Last update: 2016-03-15 08:21    [W:0.312 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site