Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Tue, 15 Mar 2016 18:30:37 +0000 | Subject | Re: [PATCH 2/3] [media] am437x-vfpe: fix typo in vpfe_get_app_input_index |
| |
Hi Arnd,
Thanks for the patch.
On Mon, Mar 14, 2016 at 10:40 PM, Arnd Bergmann <arnd@arndb.de> wrote: > gcc-6 points out an obviously silly comparison in vpfe_get_app_input_index(): > > drivers/media/platform/am437x/am437x-vpfe.c: In function 'vpfe_get_app_input_index': > drivers/media/platform/am437x/am437x-vpfe.c:1709:27: warning: self-comparison always evaluats to true [-Wtautological-compare] > client->adapter->nr == client->adapter->nr) { > ^~ > > This was introduced in a slighly incorrect conversion, and it's > clear that the comparison was meant to compare the iterator > to the current subdev instead, as we do in the line above. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: d37232390fd4 ("[media] media: am437x-vpfe: match the OF node/i2c addr instead of name") > ---
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cheers, --Prabhakar Lad
| |