Messages in this thread | | | Date | Tue, 15 Mar 2016 16:27:55 +0100 | Subject | Re: [PATCH] gpio: 74x164: add dt support for nxp's 74x594 | From | Geert Uytterhoeven <> |
| |
On Tue, Mar 15, 2016 at 12:32 AM, Nicolas Saenz Julienne <nicolassaenzj@gmail.com> wrote: > The chip is also an 8 bit shift register which works out of the box as a GPO > expander with this patch > > Signed-off-by: Nicolas Saenz Julienne <nicolassaenzj@gmail.com> > --- > Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 4 +++- > drivers/gpio/gpio-74x164.c | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-74x164.txt b/Documentation/devicetree/bindings/gpio/gpio-74x164.txt > index cc26080..ce1b223 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-74x164.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio-74x164.txt > @@ -1,7 +1,9 @@ > * Generic 8-bits shift register GPIO driver > > Required properties: > -- compatible : Should be "fairchild,74hc595" > +- compatible: Should contain one of the following: > + "fairchild,74hc595" > + "nxp,74lvc594"
Why did you choose the "lvc" variant?
Ideally, you want to put the oldest "manuf,74x594" variant here. I once read it was Motorola who invented the 7459x parts, to interface with SPI.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |