Messages in this thread | | | Subject | Re: [PATCH v2] rtc: s3c: Don't print an error on probe deferral | From | Javier Martinez Canillas <> | Date | Mon, 14 Mar 2016 18:07:36 -0300 |
| |
Hello Joe,
On 03/14/2016 05:30 PM, Joe Perches wrote: > On Mon, 2016-03-14 at 17:25 -0300, Javier Martinez Canillas wrote: >> The clock and source clock looked up by the driver may not be available >> just because the clock controller driver was not probed yet so printing >> an error in this case is not correct and only adds confusion to users. >> >> However, knowing that a driver's probe was deferred may be useful so it >> can be printed as debug information. > > Hello again Javier: >> + dev_dbg(&pdev->dev, "probe deferred due missing rtc clk\n"); > > Again, intelligible English would not use "due" > but would use "due to" or "because of". >
Ok, I'll post another version then. I hope the third time's the charm...
Alexandre, do you have any other comments before I re-spin this patch?
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |