Messages in this thread | | | Date | Sat, 12 Mar 2016 16:31:07 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v3 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops |
| |
* Andy Lutomirski <luto@kernel.org> wrote:
> +bool ex_handler_rdmsr_unsafe(const struct exception_table_entry *fixup, > + struct pt_regs *regs, int trapnr) > +{ > + WARN(1, "unsafe MSR access error: RDMSR from 0x%x", > + (unsigned int)regs->cx);
Please make this WARN_ONCE(). There's no point in locking up the system with WARN() spam, should this trigger frequently.
> + WARN(1, "unsafe MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x)\n", > + (unsigned int)regs->cx, > + (unsigned int)regs->dx, (unsigned int)regs->ax);
Ditto.
Thanks,
Ingo
| |