lkml.org 
[lkml]   [2016]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v0] Add tw5864 driver
On Fri, 11 Mar 2016 09:00:18 +0100
Hans Verkuil <hverkuil@xs4all.nl> wrote:
> The reason is likely to be the tw5864_queue_setup function which has
> not been updated to handle CREATE_BUFS support correctly. It should
> look like this:
>
> static int tw5864_queue_setup(struct vb2_queue *q,
> unsigned int *num_buffers,
> unsigned int *num_planes, unsigned int
> sizes[], void *alloc_ctxs[])
> {
> struct tw5864_input *dev = vb2_get_drv_priv(q);
>
> if (q->num_buffers + *num_buffers < 12)
> *num_buffers = 12 - q->num_buffers;
>
> alloc_ctxs[0] = dev->alloc_ctx;
> if (*num_planes)
> return sizes[0] < H264_VLC_BUF_SIZE ? -EINVAL : 0;
>
> sizes[0] = H264_VLC_BUF_SIZE;
> *num_planes = 1;
>
> return 0;
> }

Thanks for suggestion, but now the failure looks this way:

Streaming ioctls:
test read/write: OK
fail: v4l2-test-buffers.cpp(297): g_field() == V4L2_FIELD_ANY
fail: v4l2-test-buffers.cpp(703): buf.check(q, last_seq)
fail: v4l2-test-buffers.cpp(976): captureBufs(node, q, m2m_q, frame_count, false)
test MMAP: FAIL

Will check that later. If you have any suggestions, I would be very
grateful.

\
 
 \ /
  Last update: 2016-03-11 10:21    [W:0.098 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site