lkml.org 
[lkml]   [2016]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V14 5/9] dma: qcom_hidma: implement lower level hardware interface
    From
    Date
    On 3/11/2016 11:32 AM, Vinod Koul wrote:
    >>>> memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0],
    >>>> > >> + TRE_SIZE);
    > This one
    >
    >>>> > >> + lldev->tx_status_list[tre->idx].err_code = 0;
    >>>> > >> + lldev->tx_status_list[tre->idx].err_info = 0;
    >>>> > >> + tre->queued = 1;
    >>>> > >> + lldev->pending_tre_count++;
    >> >
    >> > Is this the only one without alignment? I couldn't understand what you mean by
    >> > above one?
    > quoting Coding Style:
    >
    > Statements longer than 80 columns will be broken into sensible chunks, unless
    > exceeding 80 columns significantly increases readability and does not hide
    > information.

    > "Descendants are always substantially shorter than the parent and
    > are placed substantially to the right."
    >
    >

    Sorry for my poor English. I never got this rule.

    Which one is a "substantially" right? Can you give me an example?

    I need to understand how you'd write this to satisfy the above rule.

    like this:

    memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0],
    TRE_SIZE);

    or

    memcpy(lldev->tre_ring + lldev->tre_write_offset,
    &tre->tre_local[0], TRE_SIZE);

    or

    memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0],
    TRE_SIZE);

    or

    memcpy(lldev->tre_ring + lldev->tre_write_offset,
    &tre->tre_local[0],
    TRE_SIZE);

    --
    Sinan Kaya
    Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

    \
     
     \ /
      Last update: 2016-03-11 18:21    [W:2.868 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site