Messages in this thread | | | Subject | Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic | From | Sylwester Nawrocki <> | Date | Fri, 11 Mar 2016 14:09:00 +0100 |
| |
On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: > Thanks, I just noticed another similar issue in the driver now and is > that fimc_is_parse_sensor_config() uses the same struct device_node * > for looking up the I2C sensor, port and endpoint and thus not doing a > of_node_put() for all the nodes on the error path. > > I think the right fix is to have a separate struct device_node * for > each so their reference counter can be incremented and decremented.
Yes, the node reference count is indeed not handled very well there, feel free to submit a patch to fix that bug.
-- Regards, Sylwester
| |