lkml.org 
[lkml]   [2016]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 3/9] dma-mapping: add dma_{map,unmap}_resource
    On Thu, Mar 10, 2016 at 10:47:10PM -0800, Dan Williams wrote:
    > I think it is confusing to use the dma_ prefix for this peer-to-peer
    > mmio functionality. dma_addr_t is a device's view of host memory.
    > Something like bus_addr_t bus_map_resource(). Doesn't this routine
    > also need the source device in addition to the target device? The
    > resource address is from the perspective of the host cpu, it may be a
    > different address space in the view of two devices relative to each
    > other.

    Is it supposed to be per-mmio? It's in dma-mapping ops, and has dma
    in the name, so I suspected it's for some form of peer dma. But given
    that our dma APIs reuqire a struct page backing I have no idea how this
    even supposed to work, and this little documentation blurb still doesn't
    clear that up.

    So for now I'd like to NAK this patch until the use case can be
    explained clearly, and actually works.

    \
     
     \ /
      Last update: 2016-03-11 12:41    [W:3.880 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site