Messages in this thread | | | Date | Thu, 10 Mar 2016 11:28:18 -0800 | From | Brian Norris <> | Subject | Re: checkpatch.pl false positive: FSF mailing address |
| |
On Thu, Mar 10, 2016 at 11:25:55AM -0800, Joe Perches wrote: > On Thu, 2016-03-10 at 11:15 -0800, Brian Norris wrote: > > On Thu, Mar 10, 2016 at 11:08 AM, Joe Perches <joe@perches.com> wrote: > > Hey again Brian. > > > > Yeah, it's amusing. It's also likely not something worth > > > bothering with though as the likelihood of fixing it is low > > > and eventually the FSF warning will be minimized or removed > > > as no longer necessary. > > An easy improvement: don't use "ignore case" for the regex. > > Maybe, but: > > drivers/pcmcia/bfin_cf_pcmcia.c: * if not, write to the free software foundation, > > Of course there's only one of those too. > > Mostly, it's a "I just don't care very much" warning. > > If you care enough to submit a patch removing the "/i" > from the regex, please do and cc Andrew Morton too.
Maybe I will.
> > > checkpatch is stupid, false positives will always exist. > > I'd almost rather have people understand this.
Then perhaps I'll also patch this note out:
NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
Regards, Brian
| |