lkml.org 
[lkml]   [2016]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] KVM: Remove redundant smp_mb() in the kvm_mmu_commit_zap_page()
From
Date


On 10/03/2016 16:26, Paolo Bonzini wrote:
> Compared to smp_load_acquire(), smp_mb() adds an ordering between stores
> and loads.

Here, the ordering is load-store, hence...

> The load of kvm->tlbs_dirty should then be
>
> /*
> * Read tlbs_dirty before setting KVM_REQ_TLB_FLUSH in
> * kvm_make_all_cpus_request. This
> */
> long dirty_count = smp_load_acquire(kvm->tlbs_dirty);
>
> Tianyu, I think Xiao provided the information that I was missing. Would
> you like to prepare the patch?

Thanks,

Paolo

\
 
 \ /
  Last update: 2016-03-10 17:01    [W:0.094 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site