Messages in this thread | | | Date | Tue, 1 Mar 2016 08:24:56 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/3] panic: Export panic_cpu and nmi_panic_self_stop |
| |
On Tue, Mar 01, 2016 at 10:50:37AM +0900, Hidehiro Kawai wrote: > Export panic_cpu and nmi_panic_self_stop symbols for modules which > use nmi_panic() macro. > > Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Borislav Petkov <bp@suse.de> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Michal Hocko <mhocko@suse.com> > Cc: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> > Cc: Vitaly Kuznetsov <vkuznets@redhat.com> > Cc: Tejun Heo <tj@kernel.org> > --- > kernel/panic.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/panic.c b/kernel/panic.c > index d96469d..f4e8035 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -69,8 +69,10 @@ void __weak nmi_panic_self_stop(struct pt_regs *regs) > { > panic_smp_self_stop(); > } > +EXPORT_SYMBOL(nmi_panic_self_stop); > > atomic_t panic_cpu = ATOMIC_INIT(PANIC_CPU_INVALID); > +EXPORT_SYMBOL(panic_cpu);
Can we make nmi_panic() at least a proper function and export that instead of exporting all those implementation details...?
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |