lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8723au: Fix line longer than 80 columns.
On Sat, Feb 27, 2016 at 10:48:56AM -0800, Joe Perches wrote:
> On Sat, 2016-02-27 at 10:28 -0800, Edward Lipinsky wrote:
> > This patch fixes the checkpatch.pl warning:
> > WARNING: line over 80 characters
> []
> > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> []
> > @@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
> >   }
> >   spin_unlock_bh(&pacl_node_q->lock);
> >  
> > - DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
> > + DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__,
> > +   pacl_list->num);
>
> It's generally nicer to break the line at the end
> of the format sting like:
>
> DBG_8723A("%s, free acl_node_queue, num =%d\n",
> __func__, pacl_list->num);
>
> though it'd be even better to convert all of these
> DBG_8723A uses to pr_debug
>
> $ git ls-files drivers/staging/rtl8723au/ | \
>   xargs sed -r -i \
> -e 's/\bDBG_8723A\b/pr_debug/g' \
>   -e 's/\bMSG|8723A\b/pr_debug/g'
>

Thanks for the feedback. I will submit an updated patch.

Ed

\
 
 \ /
  Last update: 2016-03-01 18:41    [W:0.886 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site