Messages in this thread | | | Date | Wed, 2 Mar 2016 07:34:21 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation |
| |
On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote: > On 29.02.2016 21:58, Laxman Dewangan wrote: >> use macro REGMAP_IRQ_REG from regmap.h to initialise the >> regmap irq table for max77686. > Why? Any benefits? > > I think it is better coding to use macro for member initializations instead of doing it locally and it improves readability.
I got the similar comment from Lee's in my MFD patches to use macro for such initialization and I agreed with him.
As I was here on this driver, thought to use macro.
| |