lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 059/130] megaraid_sas: Do not use PAGE_SIZE for max_sectors
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: sumit.saxena@avagotech.com <sumit.saxena@avagotech.com>

    commit 357ae967ad66e357f78b5cfb5ab6ca07fb4a7758 upstream.

    Do not use PAGE_SIZE marco to calculate max_sectors per I/O
    request. Driver code assumes PAGE_SIZE will be always 4096 which can
    lead to wrongly calculated value if PAGE_SIZE is not 4096. This issue
    was reported in Ubuntu Bugzilla Bug #1475166.

    Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
    Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>
    Reviewed-by: Tomas Henzl <thenzl@redhat.com>
    Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/megaraid/megaraid_sas.h | 2 ++
    drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
    2 files changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/scsi/megaraid/megaraid_sas.h
    +++ b/drivers/scsi/megaraid/megaraid_sas.h
    @@ -334,6 +334,8 @@ enum MR_EVT_ARGS {
    MR_EVT_ARGS_GENERIC,
    };

    +
    +#define SGE_BUFFER_SIZE 4096
    /*
    * define constants for device list query options
    */
    --- a/drivers/scsi/megaraid/megaraid_sas_base.c
    +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
    @@ -3821,7 +3821,7 @@ static int megasas_init_fw(struct megasa
    }
    }
    instance->max_sectors_per_req = instance->max_num_sge *
    - PAGE_SIZE / 512;
    + SGE_BUFFER_SIZE / 512;
    if (tmp_sectors && (instance->max_sectors_per_req > tmp_sectors))
    instance->max_sectors_per_req = tmp_sectors;
    \
     
     \ /
      Last update: 2016-03-02 03:41    [W:4.028 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site