lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 144/342] mmc: sdhci: Allow override of get_cd() called from sdhci_request()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Adrian Hunter <adrian.hunter@intel.com>

    commit 8d28b7a72fe18bcdcdb047243ba8fec36b149955 upstream.

    Drivers may need to provide their own get_cd() mmc host op, but
    currently the internals of the current op (sdhci_get_cd()) are
    provided by sdhci_do_get_cd() which is also called from
    sdhci_request().

    To allow override of the get_cd functionality, change sdhci_request()
    to call ->get_cd() instead of sdhci_do_get_cd().

    Note, in the future the call to ->get_cd() will likely be removed
    from sdhci_request() since most drivers don't need actually it.
    However this change is being done now to facilitate a subsequent
    bug fix.

    Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mmc/host/sdhci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mmc/host/sdhci.c
    +++ b/drivers/mmc/host/sdhci.c
    @@ -1367,7 +1367,7 @@ static void sdhci_request(struct mmc_hos
    sdhci_runtime_pm_get(host);

    /* Firstly check card presence */
    - present = sdhci_do_get_cd(host);
    + present = mmc->ops->get_cd(mmc);

    spin_lock_irqsave(&host->lock, flags);
    \
     
     \ /
      Last update: 2016-03-02 02:21    [W:3.638 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site