lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: powerpc/perf/hv-gpci: Increase request buffer size
Michael Ellerman [mpe@ellerman.id.au] wrote:
> Here you read from bytes[i] where i can be > 1 (AFAICS).

Yes, buffer is large enough and I thought this construct of
array was used in a several places. Maybe they are being
changed out now (struct pid has one such usage).

>
> That's fishy at best, and newer GCCs just don't allow it.

Ah, ok.
>
> I think you could do this and it would work, but untested:
>
> struct hv_gpci_request_buffer {
> struct hv_get_perf_counter_info_params params;
> uint8_t bytes[4096 - sizeof(struct hv_get_perf_counter_info_parms)];

There is a macro for this computation in that file. I could have
used that. Will change it and repost.

Thanks,

Sukadev

\
 
 \ /
  Last update: 2016-02-10 04:21    [W:0.042 / U:33.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site