lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/5] iio: hmc5843: Fix comment style warnings
From
Date
On 07/02/16 22:21, Cristina Moraru wrote:
> Fix comment style warnings in order to comply with Coding Style
> standard provided by Documentation/CodingStyle.
>
> This patch solves following issue found with checkpatch:
> WARNING: Block comments use a trailing */ on a separate line
>
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
I've applied this, but with a few additions... see inline.
> ---
> drivers/staging/iio/magnetometer/hmc5843.h | 4 ++--
> drivers/staging/iio/magnetometer/hmc5843_i2c.c | 2 +-
> drivers/staging/iio/magnetometer/hmc5843_spi.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.h b/drivers/staging/iio/magnetometer/hmc5843.h
> index 06f35d3..cb284cf 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.h
> +++ b/drivers/staging/iio/magnetometer/hmc5843.h
> @@ -8,7 +8,7 @@
> * it under the terms of the GNU General Public License version 2 as
> * published by the Free Software Foundation.
> *
Dropped the unwanted empty comment line as it doesn't add anything and we
might as well clean it up whilst here.
> - * */
> + */
>
> #ifndef HMC5843_CORE_H
> #define HMC5843_CORE_H
> @@ -38,7 +38,7 @@ enum hmc5843_ids {
> * @regmap: hardware access register maps
> * @variant: describe chip variants
> * @buffer: 3x 16-bit channels + padding + 64-bit timestamp
> - **/
> + */
> struct hmc5843_data {
> struct device *dev;
> struct mutex lock;
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_i2c.c b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> index 3e06ceb..6f7b8fb 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_i2c.c
> @@ -8,7 +8,7 @@
> * it under the terms of the GNU General Public License version 2 as
> * published by the Free Software Foundation.
> *
snap
> - * */
> + */
>
> #include <linux/module.h>
> #include <linux/i2c.h>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_spi.c b/drivers/staging/iio/magnetometer/hmc5843_spi.c
> index 1549192..85adcdd 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_spi.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_spi.c
> @@ -7,7 +7,7 @@
> * it under the terms of the GNU General Public License version 2 as
> * published by the Free Software Foundation.
> *
snap.
> - * */
> + */
>
> #include <linux/module.h>
> #include <linux/spi/spi.h>
>

\
 
 \ /
  Last update: 2016-02-09 23:21    [W:0.070 / U:3.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site