lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality
Date
On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:
>
> The descriptors are usable by different drivers, one driver may use it as
> buf ptr/ len, other for something else. So they should remain as generic
> and it is up to individual drivers to use it in whatever way it requires.
> My suggestion is to rename pad field in struct knav_dma_desc to sw_data
> to avoid confusion. i.e
>
> + __le32 pad[4];
>
> to
>
> + __le32 sw_data[4];
>

If the hardware doesn't access them, they can probably just be u32
and not do any byte swapping.

Arnd

\
 
 \ /
  Last update: 2016-02-09 21:01    [W:0.106 / U:7.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site