lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read request
On Fri, Dec 11, 2015 at 09:39:58AM +0530, Vignesh R wrote:

> + if (spi_flash_read_supported(spi)) {
> + struct spi_flash_read_message msg;
> + int ret;
> +
> + msg.buf = buf;
> + msg.from = from;
> + msg.len = len;
> + msg.read_opcode = nor->read_opcode;
> + msg.addr_width = nor->addr_width;
> + msg.dummy_bytes = dummy;
> + /* TODO: Support other combinations */
> + msg.opcode_nbits = SPI_NBITS_SINGLE;
> + msg.addr_nbits = SPI_NBITS_SINGLE;
> + msg.data_nbits = m25p80_rx_nbits(nor);
> +
> + ret = spi_flash_read(spi, &msg);
> + *retlen = msg.retlen;
> + return ret;

Looking at this I can't help but think that spi_flash_read() ought to
have the stub in rather than the caller. But given that we're pretty
much only ever expecting one user I'm not 100% sure it actually matters.
Anyway, I applied the first two patches.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-02-09 21:01    [W:0.168 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site