[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client
There is different RTC I2C address for RTC block in MAX77686.
Driver is creating dummy i2c client for this address to access
the register of this IP block.

As there is no call to i2c_get_clientdata() for rtc_i2c client,
there is no need to store pointer and hence removing the call
to set client data for rtc i2c client.

Suggested-by: Krzysztof Kozlowski <>
Signed-off-by: Laxman Dewangan <>
CC: Krzysztof Kozlowski <>
CC: Javier Martinez Canillas <>
Reviewed-by: Krzysztof Kozlowski <>
Tested-by: Javier Martinez Canillas <>
Reviewed-by: Javier Martinez Canillas <>

This is new in this series based on review comment from V1.

Changes from V2:
- Rephrase description.
- Added reviewed by.

Changes from V3:
- None, become 5th on series.

Changes from V4:

Changes from V5:

Changes from V6:
Make this as 4th of series as regmap change applied independently.

drivers/mfd/max77686.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index d959ebb..bda6fd7 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c
@@ -277,7 +277,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c,
"Failed to allocate I2C device for RTC\n");
return -ENODEV;
- i2c_set_clientdata(max77686->rtc, max77686);

max77686->rtc_regmap =
 \ /
  Last update: 2016-02-09 19:21    [W:0.064 / U:1.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site