lkml.org 
[lkml]   [2016]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE
Date


> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, February 9, 2016 5:05 AM
> To: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: netdev@vger.kernel.org; KY Srinivasan <kys@microsoft.com>;
> olaf@aepfle.de; vkuznets@redhat.com; linux-kernel@vger.kernel.org;
> driverdev-devel@linuxdriverproject.org
> Subject: Re: [PATCH net-next] hv_netvsc: Increase delay for
> RNDIS_STATUS_NETWORK_CHANGE
>
> From: Haiyang Zhang <haiyangz@microsoft.com>
> Date: Tue, 2 Feb 2016 16:15:56 -0800
>
> > We simulates a link down period for RNDIS_STATUS_NETWORK_CHANGE
> > message to trigger DHCP renew. User daemons may need multiple seconds
> > to trigger the link down event. (e.g. ifplugd: 5sec, network-manager:
> > 4sec.) So update this link down period to 10 sec to properly trigger DHCP
> renew.
> >
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
>
> Two things look really bad about this to me:
>
> 1) Any value you choose is arbitrary. If some new network configuration
> daemon
> is slower, you will have to change this value again.
>
> This is _NOT_ sustainable in the long term.
>
> 2) It is completely unclear to me why this driver needs to delay at all or
> wait for anything. I see no other driver having to deal with this issue.
>
> Until you address both of these points I am not going to apply this patch.

1) I share your concern as well. Is there a universal way to immediately trigger
DHCP renew of all current and future daemons with a single event from kernel?
If not, can we put the delay (RNDIS_STATUS_NETWORK_CHANGE only) into a
tunable variable of this driver?

2) We used to have the call_usermodehelper "/etc/init.d/network restart" to
trigger DHCP renew. In commit 27a70af3f4, Vitaly has replaced it with the current
code that updates the link status with at least 2 seconds interval, so that the
"link_watch infrastructure" can send notification out. link_watch infrastructure
only sends one notification per second.

Thanks,
- Haiyang

\
 
 \ /
  Last update: 2016-02-09 17:21    [W:0.103 / U:7.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site