Messages in this thread | | | Date | Tue, 9 Feb 2016 16:18:56 +0100 | From | Radim Krčmář <> | Subject | Re: [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC existence |
| |
2016-02-09 16:06+0100, Paolo Bonzini: > On 09/02/2016 14:55, Radim Krčmář wrote: >> This is most likely going to bug on the following path: >> handle_apic_access -> kvm_lapic_set_eoi >> >> Before the change, handle_apic_access would just drop EOIs that should >> have gone to user space ... I'm not sure if we tested it, or the path is >> really never taken. > > cpu_need_virtualize_apic_accesses is needed to set > SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES (vmx_secondary_exec_control) and > SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES is required to get to > handle_apic_access.
Thanks,
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
| |